Deprecator improvements #2997
Merged
Deprecator improvements #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for removing deprecations for certain generators, this commit documents the Deprecator and how to test deprecated generators. It also adds a unit test using newly added matchers based on Rails deprecation matchers. With this change, we can remove generators in a follow up PR while having the Deprecator covered and documented.
stefannibrasil
force-pushed
the
sb-deprecator-improvements
branch
from
c53bade
to
f86ba5e
Compare
stefannibrasil
commented
Aug 30, 2024
| @@ -1,17 +1,70 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| # Based on Rails ActiveSupport Deprecator | |||
| # https://github.com/rails/rails/blob/6f0d1ad14b92b9f5906e44740fce8b4f1c7075dc/activesupport/lib/active_support/deprecation/constant_accessor.rb | |||
| # https://github.com/rails/rails/blob/main/activesupport/lib/active_support/deprecation/constant_accessor.rb | |||
There was a problem hiding this comment.
The changes here are mostly documentation and identation.
stefannibrasil
commented
Aug 30, 2024
| @@ -0,0 +1,41 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
Moved this file from test/faker/ to test/faker/support.
stefannibrasil
force-pushed
the
sb-deprecator-improvements
branch
from
a9fabc2
to
f3102de
Compare
stefannibrasil
commented
Aug 30, 2024
| @@ -6,7 +6,7 @@ source 'https://rubygems.org' | |||
| gemspec | |||
|
|
|||
| gem 'benchmark' | |||
| gem 'minitest', '5.25.0' | |||
| gem 'minitest', '5.25.1' | |||
There was a problem hiding this comment.
Ruby head was not happy with the old version. This new version works for all Ruby versions in CI.
stefannibrasil
force-pushed
the
sb-deprecator-improvements
branch
from
f3102de
to
d8b2327
Compare
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for removing deprecations for certain generators, this commit documents the Deprecator and how to test deprecated generators. It also adds a unit test using newly added matchers based on Rails deprecation matchers. This new test is independent from any "real" deprecated generator that can be removed at any time.
With this change, we can remove generators in a follow up PR while having the Deprecator covered and documented.